chore: misc fixes #2960
Merged
chore: misc fixes #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjaindev
requested review from
vikramdevtron and
vivek-devtron
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR contains miscellaneous fixes focusing on URL formatting, keyboard shortcut platform detection, overflow handling in UI components, abort controller implementation for API requests, and search parameter corrections.
Key changes:
- Fixed URL construction to remove redundant leading slash
- Added platform-specific keyboard shortcut detection (Meta for macOS, Control for others)
- Implemented proper abort controller cleanup for API requests to prevent memory leaks and handle request cancellation
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/app/details/appDetails/AppDetails.tsx | Removed redundant leading slash from URL construction |
| src/components/Navigation/Navigation.tsx | Added platform-specific keyboard shortcut display (Meta/Control) |
| src/components/CIPipelineN/VariableDataTable/VariableDataTablePopupMenu.tsx | Changed overflow behavior from auto to hidden |
| src/components/CIPipelineN/VariableDataTable/VariableConfigOverlay.tsx | Added overflow-auto class for scrollable content |
| src/components/CIPipelineN/VariableDataTable/ValueConfigOverlay.tsx | Reorganized overflow classes between parent and child elements |
| src/Pages/Shared/CommandBar/service.ts | Added null safety check for helmApps property |
| src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/service.ts | Added abort signal parameter to getChartList function |
| src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplate.tsx | Implemented abort controller for initial data load with cleanup |
| src/Pages/App/CreateAppModal/service.ts | Fixed parameter name from searchKey to appNameSearch in getJobs call |
| src/Pages/App/CreateAppModal/AppClone/useDevtronCloneList.tsx | Added searchKey dependency for job list refetch |
| src/Pages/App/CreateAppModal/AppClone/AppCloneList.tsx | Added empty state for filtered job results and loading indicator to search |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplate.tsx
Show resolved
Hide resolved
vivek-devtron
previously approved these changes
Oct 16, 2025
AbhishekA1509
approved these changes
Oct 16, 2025
vivek-devtron
approved these changes
Oct 16, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: